sammccall added a comment.
Oops, we weren't handling the case when the newly-added overload is dominated
by an existing one. Fixed.
================
Comment at: lib/Sema/SemaCodeComplete.cpp:1300
+ auto &OverloadSet =
+ OverloadMap[std::make_pair(CurContext, Method->getName())];
+ for (const DeclIndexPair& Entry : OverloadSet) {
----------------
ilya-biryukov wrote:
> Won't this crash on `Method->getName()`? Could we add a test for that?
> Completing in a class that has a user-defined `operator==()` would probably
> do the trick.
Right! Fixed and test added. We now no longer hash the strings which is nice
too.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62582/new/
https://reviews.llvm.org/D62582
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
