ilya-biryukov added a comment.

In D62573#1520641 <https://reviews.llvm.org/D62573#1520641>, @kadircet wrote:

> Do you think it would be beneficial to add some logging for the default case 
> of that switch statement ?


We should replace `default` with all cases it covers to make sure we get a 
warning when adding a new kind.
But I'm not sure it's going to be a big improvement, maybe it would be even 
nicer to replace this with some macro magic involving `#include 
"DeclKinds.inc"`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62573/new/

https://reviews.llvm.org/D62573



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to