craig.topper added inline comments.
================ Comment at: lib/Headers/avx512bf16intrin.h:37 +/// +/// This intrinsic corresponds to the <c> EmitX86CvtBF16ToFloatExpr </c> +/// function. ---------------- skan wrote: > craig.topper wrote: > > This needs to be a comment that's useful to user's of the compiler not > > compiler developers. It can't reference an implementation function inside > > the compiler > i can not think out a comment that 's needed by users since other comments > has explained this function clearly, can i just remove this comment? Just write "This intrinsic does not correspond to a specific instruction," CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62363/new/ https://reviews.llvm.org/D62363 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits