aprantl added inline comments.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4468
}
+static void analyzeParametersModification(
----------------
/// Analyzes each function parameter to determine whether it is constant
throughout the function body.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4478
+ ExprMutationAnalyzer FuncAnalyzer(*FuncBody, Ctx);
+ if (!FuncAnalyzer.isMutated(Parm)) {
+ auto I = ParamCache.find(Parm);
----------------
```
if (FuncAnalyzer.isMutated(Parm))
continue;
```
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:4483
+ DIParm->setIsNotModified();
+ }
+ }
----------------
should the else be an assertion or are there legitimate failure cases?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58035/new/
https://reviews.llvm.org/D58035
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
