hintonda added inline comments.
================ Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() ---------------- hintonda wrote: > This is a breaking patch. What's the rational for unilaterally disabling > LLVM_ENABLE_PLUGINS. > > ``` > It gives the following errors: > -- PrintFunctionNames ignored -- Loadable modules not supported on this > platform. > -- AnnotateFunctions ignored -- Loadable modules not supported on this > platform. > -- SampleAnalyzerPlugin ignored -- Loadable modules not supported on this > platform. > -- CheckerDependencyHandlingAnalyzerPlugin ignored -- Loadable modules not > supported on this platform. > -- CheckerOptionHandlingAnalyzerPlugin ignored -- Loadable modules not > supported on this platform. > -- BugpointPasses ignored -- Loadable modules not supported on this platform. > -- TestPlugin ignored -- Loadable modules not supported on this platform. > ``` Btw, the change essentially turns off testing of plugins, and bugpoint, etc., in all the buildbots, but since it isn't reported as an error, they don't report that these tests are no longer run., Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62050/new/ https://reviews.llvm.org/D62050 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
