MaskRay added inline comments.
================ Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:217 case Triple::ppc64: - return PPCTargetMachine::PPC_ABI_ELFv1; + // if ELFv2 on target triple i.e. powerpc64-unknown-freebsd12.0-elfv2 + if (TT.getEnvironment() == llvm::Triple::ELFv2) ---------------- The initial word should be capitalized and the sentence should end with a period. At least this part of the comment (`if ELFv2 on target triple `) is redundant. I don't know if the other half `powerpc64-unknown-freebsd12.0-elfv2` is useful... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits