JonasToth added a comment. In D61850#1500330 <https://reviews.llvm.org/D61850#1500330>, @svenpanne wrote:
> In D61850#1500298 <https://reviews.llvm.org/D61850#1500298>, @JonasToth wrote: > > > [...] please ensure that e.g. clang-analyzer-* output looks proper as well > > and `-quiet` does, too. > > > OK, are there any (unit) tests which I should run? If yes, how exactly? I > have a successfully built a fork of https://github.com/llvm/llvm-project via > ninja locally, but the documentation for the various subprojects is still a > bit hard to find to me. Is there a ninja target for `clang-tidy`-related > tests? Any hints to get started would be highly appreciated. > > This and the other output-related patches are my first submissions here, and > they are intentionally simple to get the workflow right. My real intention is > trying to improve/fix the `readability-identifier-naming` check/fixer, which > still has a few issues. There are testing targets for clang-tidy and clang-tooling, i believe `ninja check-clang-tools` is includes clang-tidy (maybe `ninja check-clang-tooling` instead). If this script is actually covered by testing is not know to me, i believe not. For testing just run it over a project (e.g. parts of LLVM) with this tool instead of e.g. your distribution version of it. For general development: `clang-tools-extra/test/clang-tidy/*` has the test-cases for clang-tidy checks, which are real world code examples that cover all representative cases (in theory). 1. Write/adjust test 2. Do changes in code 3. Test with `ninja check-clang-tools` / `ninja check-clang-tooling` That usually works. If you encounter any issues feel free to ask here/IRC/mail, we are happy to help out :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61850/new/ https://reviews.llvm.org/D61850 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
