BillyONeal added a comment. In D61364#1502172 <https://reviews.llvm.org/D61364#1502172>, @ldionne wrote:
> Do you know *why* the tests are failing with libc++? I see this overload for > `insert` and it seems like it should be a better match? No, I haven't investigated. I avoid looking at libc++ product code too much for now because I want to avoid any appearance or reality of licensing conflicts... for now ;) . In D61364#1502172 <https://reviews.llvm.org/D61364#1502172>, @ldionne wrote: > I think we should just fix libc++ to do the right thing (according to the > standard). That's what I'd recommend :) In D61364#1502172 <https://reviews.llvm.org/D61364#1502172>, @ldionne wrote: > Separately, I'm not sure it's worth changing the Standard to ensure that the > `T const&` overload is selected -- I don't see a huge benefit here. Would be a code size win if both overloads are called in the same program. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61364/new/ https://reviews.llvm.org/D61364 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
