efriedma added a comment.
> If we agree that this is a good way forward, there also appears to be
> +neonfp/-neonfp additions happening in handleTargetFeatures that should
> prooooobably be happening in initFeatureMap instead?
neonfp isn't passed as a feature in the first place; there's a separate API
setFPMath which is used for that. We translate it into a target feature for
the sake of the backend. So I'm not sure what you're proposing.
------
What happens if someone specifies __attribute__((target("soft-float-abi"))) or
something like that? (There's an API isValidFeatureName to validate feature
names, but we currently don't implement it.)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61750/new/
https://reviews.llvm.org/D61750
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
