BillyONeal added a comment.

In D61366#1502073 <https://reviews.llvm.org/D61366#1502073>, @EricWF wrote:

> I'm not sure I agree with your design decision, but this patch LGTM.


I wouldn't object to a standards change to make this the case; though it is 
suboptimal to destroy all the elements needlessly.

> Are you not allowed to move the containers elements in this case?

Correct. The allocator is not POCMA and not equal, so it's functionally the 
same as doing assign(make_move_iterator(begin()), make_move_iterator(end())).

Billy3


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61366/new/

https://reviews.llvm.org/D61366



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D61366: [l... Billy Robert O'Neal III via Phabricator via cfe-commits
    • [PATCH] D6136... Billy Robert O'Neal III via Phabricator via cfe-commits
    • [PATCH] D6136... Eric Fiselier via Phabricator via cfe-commits
    • [PATCH] D6136... Billy Robert O'Neal III via Phabricator via cfe-commits
    • [PATCH] D6136... Arthur O'Dwyer via Phabricator via cfe-commits
    • [PATCH] D6136... Billy Robert O'Neal III via Phabricator via cfe-commits

Reply via email to