Szelethus accepted this revision. Szelethus added a comment. LGTM!
================ Comment at: clang/include/clang/Analysis/CFG.h:514 + CFGTerminator() { assert(!isValid()); } + CFGTerminator(Stmt *S, Kind K = StmtBranch) : Data(S, K) {} ---------------- Can we add something to check that the integer part of `Data` is actually large enough to store an object of type `Kind`, even if we add more values to the enum? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61814/new/ https://reviews.llvm.org/D61814 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits