hintonda added a comment. In D61827#1499335 <https://reviews.llvm.org/D61827#1499335>, @lebedev.ri wrote:
> In D61827#1499333 <https://reviews.llvm.org/D61827#1499333>, @hintonda wrote: > > > When I asked for a test above, I understood you to say you couldn't provide > > one, but If I misunderstood, by all means, please add the test. > > > Please do note that i have provided a testcase (godbolt link) in my very > first comment, and quoted that line when replying the previous time. > (Granted, that loop is not in a correct form for openmp, but the point > being, the current check does not diagnose it either) I'm really not sure I understand what you are trying to say. Are you saying this patch is a regression? By "false positive", do you mean that diagnoses something it shouldn't change and creates an erroneous fixit? Of that it ignores something it should fix? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61827/new/ https://reviews.llvm.org/D61827 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
