xazax.hun added a comment.
Mostly looks good, I have two slightly related nits.
================
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:127
+ StringRef IndexName, bool DisplayCTUProgress,
+ unsigned CTULoadThreshold);
----------------
I would prefer to keep the default argument for `DisplayCTUProgress`. You could
do this either by swapping the arguments or adding a default argument to
`CTULoadThreshold` as well. I think I might prefer the latter.
================
Comment at: include/clang/CrossTU/CrossTranslationUnit.h:176
std::unique_ptr<ASTImporterLookupTable> LookupTable;
+ unsigned NumASTLoaded{0u};
};
----------------
Does it make sense to call `getCrossTUDefinition` with different thresholds for
the same CTUContext? I suspect it is not, so it might make more sense to set
the threshold in the context's constructor.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59798/new/
https://reviews.llvm.org/D59798
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
