lebedev.ri added a reviewer: lebedev.ri.
lebedev.ri added a comment.

In D61749#1497162 <https://reviews.llvm.org/D61749#1497162>, @Eugene.Zelenko 
wrote:

> @JonasToth tried to implement const check, so probably const and static part 
> should be split.


I agree, there is D54943 <https://reviews.llvm.org/D54943>, which should be 99% 
ready to go, and is only stuck due to @JonasToth
time constraints, IIRC. Treating `*this` pointer should simply be a logical 
extension of
that check. (unless it already does that, or there is some other patch i forgot 
about)

I.e. let's split this, and start with `static` part.

Also, you are aware of `ExprMutationAnalyzer`?

> It's hard to tell about state of existing implementation, but you could 
> continue it or at least borrow ideas and tests.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61749/new/

https://reviews.llvm.org/D61749



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to