aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Aside from one minor nit with `auto` usage, LGTM! ================ Comment at: C:/LLVM/llvm/tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1396 @@ -1395,3 +1395,3 @@ const auto &ReferencedBlockVars = AC->getReferencedBlockVars(BC->getDecl()); - auto NumBlockVars = + const auto NumBlockVars = std::distance(ReferencedBlockVars.begin(), ReferencedBlockVars.end()); ---------------- No need for a const here; the correct change is to not use auto (here and the line above), but instead spell out the type explicitly. http://reviews.llvm.org/D16748 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits