ahatanak added inline comments.
================
Comment at: include/clang/Basic/TargetInfo.h:643
+ /// runtime, such as those using the Itanium C++ ABI.
+ virtual unsigned getExnObjectAlignment() const {
+ // Itanium says that an _Unwind_Exception has to be "double-word"
----------------
rjmccall wrote:
> CharUnits?
I added a function to ASTContext that returns CharUnits.
================
Comment at: lib/Sema/SemaExprCXX.cpp:946
+ // is larger than the minimum alignment the libc++abi runtime guarantees.
+ if (Context.getTargetInfo().getTriple().isOSDarwin()) {
+ CharUnits TypeAlign = Context.getTypeAlignInChars(Ty);
----------------
rjmccall wrote:
> Why is this a Darwin-specific check? Seems like it ought to be an
> Itanium-specific check, but it's equally applicable on Linux to
> highly-aligned types.
Except when the C++ ABI is Microsoft, this is always diagnosed.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61667/new/
https://reviews.llvm.org/D61667
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
