smeenai accepted this revision. smeenai added a comment. LGTM, neat!
================ Comment at: llvm/test/CodeGen/X86/extern_weak.ll:20-21 +; DARWIN-LABEL: _bar: +; DARWIN: cmpl $0, L_foo$non_lazy_ptr +; DARWIN: jmp _foo ## TAILCALL + ---------------- I'm not parsing this too well (it's not quite clear what the relation between `L_foo$non_lazy_ptr` and `_foo` is, but I'm assuming `$non_lazy_ptr` is some Darwin thing that gets synthesized by the `.weak_reference _foo`), but I think you're just enhancing the Darwin test rather than changing that codegen in any way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61615/new/ https://reviews.llvm.org/D61615 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
