ilya-biryukov added inline comments.
================ Comment at: clang-tools-extra/clangd/Protocol.cpp:707 + else + return false; + return true; ---------------- kadircet wrote: > kadircet wrote: > > Maybe also vlog/elog the unknown kind? So that we can easily catch new > > additions to spec. > I was referring to the `else` case down below :D Thanks for catching that! My mistake, I made the change but did not save the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits