tra added a comment. In D60907#1484756 <https://reviews.llvm.org/D60907#1484756>, @jdoerfert wrote:
> I actually don't want to preinclude anything and my arguments are (mostly) > for the OpenMP offloading code path not necessarily Cuda. > Maybe to clarify, what I want is: > > 1. Make sure the `clang/Headers/math.h` is found first if `math.h` is > included. > 2. Use a scheme similar to the one described > https://reviews.llvm.org/D47849#1483653 in `clang/Headers/math.h` > 3. Only add `math.h` function overloads in our `math.h`. **<- This is > debatable** Agreed. > 4. Include `clang/Headers/math.h` from `__clang_cuda_device_functions.h` to > avoid duplication of math function declarations. This is not needed for CUDA. `math.h` is included early on in `__clang_cuda_runtime_wrapper.h` (via `<cmath>`), so by the time `__clang_cuda_device_functions.h` is included, math.h has already been included one way or another -- either in step 3 above, or directly by the __clang_cuda_runtime_wrapper.h Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
