Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land.
Great patch! There is only a design problem: You have negated every `isSmall()` condition looks like you could write `isLarge()` instead but there is no connection between these functions. Could you rename or redesign them? The following would be cool: `isLarge()` iff `!isSmalll` and `isSmall()` iff `!isLarge()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits