martong added a comment.

In D60934#1475908 <https://reviews.llvm.org/D60934#1475908>, @Tyker wrote:

> Fixed issues form feedback by @martong


Thank you for addressing the comments. `ASTImporter.cpp` and 
`ASTStructuralEquivalence.cpp` looks good to me now. However, about the 
equivalence check, do you think it would be possible to have a unit test for 
explicit(bool) in `StructuralEquivalenceTest.cpp`? That test would exercise the 
static `EquivalentExplicit()` function too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60934/new/

https://reviews.llvm.org/D60934



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to