ormris added inline comments.
================
Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220
+ BarHeader = testPath("sub/bar.h");
+ EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\"");
}
----------------
sammccall wrote:
> ormris wrote:
> > Quick nit: This test won't work on Windows as it only tests for POSIX-style
> > path separators. You could easily add a Windows ifdef, though.
> testPath() returns an appropriate native path, and calculate() returns an
> #include string (which always uses /).
> The "../" on line 217 looks a little more suspicious, but I think the clang
> driver might silently Do What I Mean here.
> Are you seeing test failures?
Yes, here's the output.
```
[ RUN ] HeadersTest.ShortenedInclude
C:\llvm\tools\clang\tools\extra\unittests\clangd\HeadersTests.cpp(220): error:
Expected: calculate(BarHeader)
Which is: "\"sub\\bar.h\""
To be equal to: "\"sub/bar.h\""
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60873/new/
https://reviews.llvm.org/D60873
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
