ilya-biryukov accepted this revision.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/AST.cpp:112
if (!Out.str().empty()) {
- // FIXME(ibiryukov): do not show args not explicitly written by the user.
- if (auto *ArgList = getTemplateSpecializationArgs(ND))
----------------
kadircet wrote:
> kadircet wrote:
> > ilya-biryukov wrote:
> > > Where did this FIXME go? Is this now fixed?
> > Yes, since `printTemplateArgsAsWritten` prints the args as written in the
> > code(see changes in file
> > clang-tools-extra/unittests/clangd/FindSymbolsTests.cpp, especially the
> > tests with a FIXME).
> >
> > Of course it still has the caveat of frienddecls, but I think the fixme
> > inside `printTemplateArgsAswritten` is the one covering that case, not this
> > one.
> This part of the change has been incorporated into parent change at D59639
> per reviewer's request.
LG. Just wanted to make sure it's not lost. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59641/new/
https://reviews.llvm.org/D59641
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
