akhuang added a comment.
Looks good- if we remove `not` there are a few other things that should be
removed
================
Comment at: clang/utils/creduce-clang-crash.py:138
if "fatal error:" in msg_re:
self.is_crash = False
break
----------------
also wouldn't need `self.is_crash`
================
Comment at: clang/utils/creduce-clang-crash.py:178
crash_flag = "--crash" if self.is_crash else ""
----------------
We should remove `crash_flag` as well
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60572/new/
https://reviews.llvm.org/D60572
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
