sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/CodeComplete.cpp:345 + Completion.Origin |= SymbolOrigin::Identifier; + Completion.Name = C.IdentifierResult->Name; + } ---------------- Completion.Kind = CompletionItemKind::Text ================ Comment at: clangd/CodeComplete.cpp:1317 + ID.References = IDAndCount.second; + if (ID.Name == CCPrefix.Name) // Decrement typed filter count. + --ID.References; ---------------- comment should explain why, rather than what :-) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60126/new/ https://reviews.llvm.org/D60126 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
