nridge marked an inline comment as done.
nridge added inline comments.
================
Comment at: clang-tools-extra/unittests/clangd/TypeHierarchyTests.cpp:405
+ *Result,
+ AllOf(WithName("S"), WithKind(SymbolKind::Struct),
+ Parents(AllOf(WithName("S"), WithKind(SymbolKind::Struct),
----------------
sammccall wrote:
> Sorry, I realize this isn't related to this patch, but I didn't see the final
> form of the previous one.
>
> This should be `WithName("S<0>"), ... Parents(AllOf(WithName("S<1>")), ...)`.
> S is the name of the template, not the name of the type.
>
> Can you add a fixme?
(I looked into what it would take to fix this, and it seems like we need
D59639, so I'm going to wait for that.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59756/new/
https://reviews.llvm.org/D59756
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
