Author: nico Date: Thu Apr 4 13:08:04 2019 New Revision: 357719 URL: http://llvm.org/viewvc/llvm-project?rev=357719&view=rev Log: check-clang-tools: Actually build and run XPC test
The CMake variable controlling if XPC code is built is called CLANGD_BUILD_XPC but three places unintentionally checked the non-existent variable CLANGD_BUILD_XPC_SUPPORT instead, which (due to being nonexistent, and due to cmake) always silently evaluated to false. Luckily the test still seems to pass, despite never running after being added almost 3 months ago in r351280. Differential Revision: https://reviews.llvm.org/D60120 Modified: clang-tools-extra/trunk/test/CMakeLists.txt clang-tools-extra/trunk/test/lit.site.cfg.py.in Modified: clang-tools-extra/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/CMakeLists.txt?rev=357719&r1=357718&r2=357719&view=diff ============================================================================== --- clang-tools-extra/trunk/test/CMakeLists.txt (original) +++ clang-tools-extra/trunk/test/CMakeLists.txt Thu Apr 4 13:08:04 2019 @@ -17,7 +17,7 @@ string(REPLACE ${CMAKE_CFG_INTDIR} ${LLV llvm_canonicalize_cmake_booleans( CLANG_ENABLE_STATIC_ANALYZER - CLANGD_BUILD_XPC_SUPPORT) + CLANGD_BUILD_XPC) configure_lit_site_cfg( ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in @@ -70,7 +70,7 @@ set(CLANG_TOOLS_TEST_DEPS clang ) -if(CLANGD_BUILD_XPC_SUPPORT) +if(CLANGD_BUILD_XPC) list(APPEND CLANG_TOOLS_TEST_DEPS clangd-xpc-test-client) endif() Modified: clang-tools-extra/trunk/test/lit.site.cfg.py.in URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/lit.site.cfg.py.in?rev=357719&r1=357718&r2=357719&view=diff ============================================================================== --- clang-tools-extra/trunk/test/lit.site.cfg.py.in (original) +++ clang-tools-extra/trunk/test/lit.site.cfg.py.in Thu Apr 4 13:08:04 2019 @@ -11,7 +11,7 @@ config.clang_libs_dir = "@SHLIBDIR@" config.python_executable = "@PYTHON_EXECUTABLE@" config.target_triple = "@TARGET_TRIPLE@" config.clang_staticanalyzer = @CLANG_ENABLE_STATIC_ANALYZER@ -config.clangd_xpc_support = @CLANGD_BUILD_XPC_SUPPORT@ +config.clangd_xpc_support = @CLANGD_BUILD_XPC@ # Support substitution of the tools and libs dirs with user parameters. This is # used when we can't determine the tool dir at configuration time. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
