AlexeySotkin added a comment. In D59985#1454676 <https://reviews.llvm.org/D59985#1454676>, @Anastasia wrote:
> In D59985#1454660 <https://reviews.llvm.org/D59985#1454660>, @AlexeySotkin > wrote: > > > In D59985#1454629 <https://reviews.llvm.org/D59985#1454629>, @Anastasia > > wrote: > > > > > In D59985#1453312 <https://reviews.llvm.org/D59985#1453312>, > > > @AlexeySotkin wrote: > > > > > > > Alternative way to fix it is to use `isNullPointerConstant` like we do > > > > in `SemaOpenCLBuiltinEnqueueKernel`. So in case we have a zero literal > > > > value we can emit `ConstantPointerNull` directly, without > > > > `EmitScalarExpr` . > > > > > > > > > Ok and if it's not 0 the code gets rejected? > > > > > > It must be rejected by SemaOpenCLBuiltinEnqueueKernel and it is already > > done https://godbolt.org/z/MFN3VU > > > Ok, cool. Perhaps this is indeed a cleaner approach then? Ok, I'll update the patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59985/new/ https://reviews.llvm.org/D59985 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
