dblaikie added a comment. In D59673#1438888 <https://reviews.llvm.org/D59673#1438888>, @aaronpuchert wrote:
> In D59673#1438716 <https://reviews.llvm.org/D59673#1438716>, @dblaikie wrote: > > > Use llvm-dwarfdump rather than llvm-objdump to dump the contents of the > > debug_info section and test the dwo_name there (rather than dumping hex) > > > I didn't know about llvm-dwarfdump, I wondered why llvm-objdump wouldn't > pretty-print the debug info as objdump does. That makes a lot of sense then. > > > probably the objdump part of the test isn't needed? > > Actually I only need to check that the DWO file is there (under the proper > file name). Any ideas? Ah, fair. You could actually test the dwo_name is accurate in the .dwo file (I added the dwo_name to the .dwo file so that multi-level dwp error messages could be more informative) >> (& I guess there's an LLVM patch to add the rest of this functionality?) > > What do we have to do there? Should we add the option to `llc` as well? Yep - pretty much anything in MCOptions should be surfaced through llc for llvm-level testing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
