MaskRay marked 4 inline comments as done. MaskRay added inline comments.
================ Comment at: lib/Driver/ToolChains/Clang.cpp:3167 + // But -gsplit-dwarf is not a g_Group option, hence we have to check the + // order explicitly. If -gsplit-dwarf wins, we fix DebugInfoKind later. + // This gets a bit more complicated if you've disabled inline info in ---------------- probinson wrote: > Regarding `If -gsplit-dwarf wins, we fix DebugInfoKind later.` > Is that still true? It looks like -gsplit-dwarf is handled here now, because > you removed the compensating code from lines 3268-3269. Deleted. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
