NoQ added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/Taint.h:8 +// +//===----------------------------------------------------------------------===// +// ---------------- Charusso wrote: > Outdated header-blurb. Whooooooooooops! Thanks!! ================ Comment at: clang/lib/StaticAnalyzer/Checkers/Taint.h:81 + +void dumpTaint(ProgramStateRef State); + ---------------- Charusso wrote: > We left the `ProgramState::dump()' context so what about just `dump()`? I'm doing `using namespace taint;` everywhere, so that'd make the code look like `dump(State)` which would look quite ambiguous to a human. Additionally, this function only needs to be called once, so it's not a problem if it's a bit long. Also, wait, i didn't really call it even once. I.e., i forgot to implement `GenericTaintChecker::printState()` to print taint (now that it's not state-specific, there must be a checker responsible for this, and i'm casting my vote for `GenericTaintChecker` out of 1 potential candidates). Let me fix it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59861/new/ https://reviews.llvm.org/D59861 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
