ilya-biryukov added a comment.

I'm happy to assess the performance costs of this change if needed (the 
function is obviously on the hot path), but I hope this won't add any 
significant performance costs.
Also happy to consider alternative approaches to collect the tokens when 
preprocessing, the current implementation is complicated (search for 
'TokenCollector' in D59887 <https://reviews.llvm.org/D59887>) and my intuition 
is that moving parts of it to the preprocessor should simplify things 
considerably.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59885/new/

https://reviews.llvm.org/D59885



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to