riccibruno added a comment. Before any further review, could you please run `clang-format` on your patch (but not necessarily on the tests and not on the `*.td` files), wrap lines to 80 cols, and in general use complete sentences in comments (that is with proper punctuation and capitalization) ? To run `clang-format` on your patch you can use `clang-format-diff`. This is the command I use :
`git diff -U0 --no-color --no-prefix --cached | clang-format-diff-7 -style=LLVM -i -v`, with `--cached` replaced appropriately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
