a_sidorin added a subscriber: davide.
a_sidorin added a comment.
Hi Shafik,
Honestly, I was always wondering what does HandleNameConflict actually do. Its
implementation in ASTImporter is trivial and I don't see any of its overrides
in LLDB code too. Why do we check its result to be non-empty is a question to
me as well. And the more I look at it (and the bug you pointed in it), the more
I think there is something wrong with it. Maybe it is better to just remove it
at all? I hope LLDB developers have more knowledge about it. Shafik, Davide
@davide , do you know its actual purpose?
================
Comment at: lib/AST/ASTImporter.cpp:2463
if (!ConflictingDecls.empty()) {
- Name = Importer.HandleNameConflict(Name, DC, IDNS,
+ Name = Importer.HandleNameConflict(SearchName, DC, IDNS,
ConflictingDecls.data(),
----------------
If I understand correctly, this will replace Name with SearchName causing an
anonymous enum to be imported as a named a few lines below. It doesn't look
like a correct behaviour to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59665/new/
https://reviews.llvm.org/D59665
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
