On Fri, Mar 8, 2019 at 5:06 PM Aaron Ballman <aa...@aaronballman.com> wrote: > > On Wed, Feb 6, 2019 at 12:43 AM Dan Gohman <sunf...@mozilla.com> wrote: > > > > > > > > On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman <aa...@aaronballman.com> > > wrote: > >> > >> On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman <sunf...@mozilla.com> wrote: > >> > > >> > > >> > Indeed, and the existing import_module attribute needs these tests as > >> > well. I'll write some and add them in a follow-up patch. > >> > > >> > Thanks for the review! > >> > >> Any time! I haven't seen that follow-up patch yet though; did it fall > >> off your radar? > > > > > > Yes, it's still on my radar. > > It's been a month and it still seems like this hasn't been taken care > of. The usual expectation is to handle post-commit feedback > "immediately". Can you please address these concerns?
Ping. ~Aaron > > ~Aaron > > > > > Dan > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
