mgorny marked 5 inline comments as done.
mgorny added inline comments.
================
Comment at: ELF/Config.h:191
bool ZGlobal;
+ GnuStackKind ZGnustack;
bool ZHazardplt;
----------------
ruiu wrote:
> Members are (roughly) sorted alphabetically, so move this below the last
> boolean member.
I don't really comprehend the sort key here but done ;-).
================
Comment at: ELF/Driver.cpp:369
S == "nodelete" || S == "nodlopen" || S == "noexecstack" ||
+ S == "nognustack" ||
S == "nokeep-text-section-prefix" || S == "norelro" || S == "notext"
||
----------------
ruiu wrote:
> If you have clang-format, please run it on this file.
File or function? Because the former would add some irrelevant changes to the
diff, so if at all, I'd rather do it separately. File I've kept unformatted to
make the patch easier to read. I've reformatted it now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56554/new/
https://reviews.llvm.org/D56554
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
