ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/index/CanonicalIncludes.cpp:111 - {"std::addressof", "<memory>"}, - // Map symbols in <iosfwd> to their preferred includes. {"std::basic_filebuf", "<fstream>"}, ---------------- nit: as these symbols are not covered by the new mapping, I think this comment is still meaningful. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits