nridge added a comment. > In D56370#1424180 <https://reviews.llvm.org/D56370#1424180>, @nridge wrote: > >> Unfortunately, there is a further problem: the Theia client-side >> implementation of type hierarchy has recently merged, and their code has >> changed so that they do require `typeHierarchy/resolve` to be supported. >> They ask for 1 level in the initial request, ignore any extra levels the >> server might send, and ask for extra levels using `typeHierarchy/resolve` >> instead. >> >> What should we do here -- seek to change Theia, or implement >> `typeHierachy/resolve` for supertypes after all? > > > Looking at > https://github.com/theia-ide/theia/pull/3802#issuecomment-455992523 inside > theia's implementation of this feature, I believe these are all subject to > change.
Note, that is a fairly old comment, and as mentioned the PR in question has recently merged. > So let's leave it as it is, even if it would mean you will be able to get > only one level of parents knowledge in theia for now. I believe it should be > addressed in theia's implementation and proposal itself(which is acutally > addressed by sam, > https://github.com/Microsoft/vscode-languageserver-node/pull/426/files#r255416980) > And if the conclusion happens to be in favor of theia's current > implementation we can always change current implementation to respond to > those queries as well. Ok, I filed a Theia issue <https://github.com/theia-ide/theia/issues/4540> about it for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
