jordan_rose added a comment.
This commit by itself doesn't change any behavior, right?
================
Comment at: clang/lib/Frontend/FrontendActions.cpp:115
CI.getPreprocessorOpts().AllowPCHWithCompilerErrors,
- FrontendOpts.IncludeTimestamps));
+ FrontendOpts.IncludeTimestamps, +CI.getLangOpts().CacheGeneratedPCH));
Consumers.push_back(CI.getPCHContainerWriter().CreatePCHContainerGenerator(
----------------
What's the `+` for?
================
Comment at: clang/lib/Frontend/FrontendActions.cpp:182
+ CI.getFrontendOpts().BuildingImplicitModule &&
+ CI.getLangOpts().isCompilingModule()));
Consumers.push_back(CI.getPCHContainerWriter().CreatePCHContainerGenerator(
----------------
Why is this the condition, as opposed to just "do this for all modules, don't
do it for PCHs"? And doesn't `BuildingImplicitModule` imply
`isCompilingModule()`? (Note that `BuildingImplicitModule` probably isn't the
same as the original condition `ImplicitModules`.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59176/new/
https://reviews.llvm.org/D59176
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
