zahiraam added inline comments.
================ Comment at: lib/Sema/SemaDecl.cpp:5975-5977 + if ((!ND.isExternallyVisible() && + (!isAnonymousNS || !(VD && VD->hasInit()))) || + (VD && VD->isStaticLocal())) { ---------------- aaron.ballman wrote: > This used to unconditionally warn, but now has predicates -- should this > still warn when not in MSVC mode? Please see new version of code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits