ahatanak marked an inline comment as done. ahatanak added inline comments.
================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:922 +def warn_objc_boxing_invalid_utf8_string : Warning< + "string is ill-formed as UTF-8 and will become a null NSString* when boxed">, + InGroup<ObjCBoxing>; ---------------- rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > Might as well use the `NSStringPointer` type we stash on Sema so that > > > this will be the right type even in more obscure environments. > > I wasn't exactly sure when `NSStringPointer` can be anything other than > > `NSString *`. > Hmm. It's possible that it can't be for boxing, but I'm pretty sure it can > be overridden for string literals, and it's not ridiculous that we'd allow > that to be changed for arbitrary boxing as well, so this is good idea > regardless. I agree, it's probably a good idea. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58729/new/ https://reviews.llvm.org/D58729 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
