NoQ added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2348
+ // Virtual bases still aren't allowed. Multiple bases are fine though.
+ for (auto B : CRD->bases()) {
+ assert(B.isVirtual() == false);
----------------
alexfh wrote:
> Should this be `const auto&`?
Whoops. Also i still somehow hate it that these aren't pointers :)
================
Comment at: clang/test/Analysis/array-struct-region.cpp:3
// RUN: %clang_analyze_cc1
-analyzer-checker=core,alpha.core,debug.ExprInspection -verify -x c++
-analyzer-config c++-inlining=constructors %s
+// RUN: %clang_analyze_cc1
-analyzer-checker=core,alpha.core,debug.ExprInspection -verify -x c++
-std=c++17 -analyzer-config c++-inlining=constructors %s
// RUN: %clang_analyze_cc1
-analyzer-checker=core,alpha.core,debug.ExprInspection -DINLINE -verify -x c %s
----------------
Szelethus wrote:
> I didn't see `-analyzer-config c++-inlining=constructors` in the bugreport --
> why is it needed?
Hmm, right, these flags are outdated long time ago. Wiped them out from this
test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59054/new/
https://reviews.llvm.org/D59054
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
