gribozavr added inline comments.
================
Comment at: clangd/GlobalCompilationDatabase.cpp:24
llvm::StringRef ResourceDir) {
+ // Clangd does not generate dependency file.
+ Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()(
----------------
kadircet wrote:
> gribozavr wrote:
> > Please don't duplicate code in comments. Explain why it shouldn't generate
> > the dependency files, or drop the comment.
> >
> >
> I am saying we are stripping "dependecy file related" commands, because
> clangd is not producing them.
> I feel like this provides the cause of the following statement, not
> replicates it. Becuase the following statement just says strip "dependency
> file related" commands.
>
> But happy to drop the comment if you insist.
What about "clangd should not write files to disk, including dependency files
requested on the command line."
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59086/new/
https://reviews.llvm.org/D59086
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
