smeenai added inline comments.
================
Comment at: clang/lib/Driver/ToolChain.cpp:89
+ P.assign(D.Dir);
+ llvm::sys::path::append(P, "..", "lib", D.getTargetTriple(), "lib");
+ if (getVFS().exists(P))
----------------
Is this supposed to append lib twice?
================
Comment at: libcxx/CMakeLists.txt:421
+ set(DEFAULT_INSTALL_PREFIX
lib${LLVM_LIBDIR_SUFFIX}/${LLVM_DEFAULT_TARGET_TRIPLE}/)
+ set(LIBCXX_LIBRARY_DIR
${LLVM_LIBRARY_OUTPUT_INTDIR}/${LLVM_DEFAULT_TARGET_TRIPLE}${LIBCXX_LIBDIR_SUFFIX})
+ set(LIBCXX_HEADER_DIR ${LLVM_BINARY_DIR})
----------------
Having the libdir suffix after the target triple looks weird ... also, the
driver code doesn't appear to be taking the possibility of a suffix into
account? I might be missing something here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59013/new/
https://reviews.llvm.org/D59013
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
