jasonliu marked 2 inline comments as done.
jasonliu added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079
+ if (log)
+ log->Printf("sorry: unimplemented for XCOFF");
+ return false;
----------------
apaprocki wrote:
> No need to be `sorry:` :) This should probably just say `error: XCOFF is
> unimplemented` to be more direct in case anything is expecting "error:" in
> the output.
Sure. Will address in next revision.
================
Comment at: llvm/lib/Support/Triple.cpp:537
return StringSwitch<Triple::ObjectFormatType>(EnvironmentName)
+ // FIXME: We have to put XCOFF before COFF;
+ // perhaps an order-independent pattern matching is desired?
----------------
apaprocki wrote:
> hubert.reinterpretcast wrote:
> > If the conclusion is that checking XCOFF before COFF is fine, then we
> > should remove the FIXME and just leave a normal comment.
> Agreed, existing code seems fine as long as there is a comment explaining
> that `xcoff` must come before `coff` in case it isn't obvious at a quick
> glance.
Sounds good. I will remove FIXME and leave a normal comment to indicate the
order dependency.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58930/new/
https://reviews.llvm.org/D58930
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
