dexonsmith added a comment.

In D58890#1417465 <https://reviews.llvm.org/D58890#1417465>, @bruno wrote:

> `InMemoryModuleCache` seems like a way more appropriate name here. Also 
> thanks for improving some of the comments.
>
> > Because of the move to Serialization we can no longer abuse the 
> > Preprocessor to forward it to the ASTReader. Besides the rename and file 
> > move, that means Preprocessor::Preprocessor has one fewer parameter and 
> > ASTReader::ASTReader has one more.
>
> Are there any C api bits that expose preprocessor stuff and also need updates?


`ninja check-clang` passes... is there anything else I should be testing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58890/new/

https://reviews.llvm.org/D58890



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D58890: Mo... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D5889... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D5889... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D5889... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D5889... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to