MyDeveloperDay added a comment. In D58731#1413695 <https://reviews.llvm.org/D58731#1413695>, @alexfh wrote:
> In D58731#1413552 <https://reviews.llvm.org/D58731#1413552>, @JonasToth wrote: > > > In D58731#1413498 <https://reviews.llvm.org/D58731#1413498>, > > @MyDeveloperDay wrote: > > > > > In D58731#1413476 <https://reviews.llvm.org/D58731#1413476>, @lewmpk > > > wrote: > > > > > > > I'm happy to land this ASAP but I don't have commit rights > > > > > > > > > So one of us could land it for you.. (I've not personally done that > > > before as I'm a bit green too! but I do have commit rights) > > > > > > Its pretty easy to get commit rights, and given your looking at multiple > > > issues I'd recommend it.. > > > (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) > > > > > > @MyDeveloperDay if you want to try the procedure out, go ahead ;) Otherwise > > I can land this patch now. > > > I'll let you folks do this. But please note that the patch wasn't generated > with arcanist, so it doesn't apply with `arc patch --nobranch`. Copy-pasting > the raw diff to `patch -p0` works though (as would downloading the diff and > feeding it to patch as a file). Make sure to put "Differential Revision: > https://reviews.llvm.org/D58731"; at the end of the message for Phabricator to > close this revision automatically. @JonasToth you are more qualified than me please go ahead... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58731/new/ https://reviews.llvm.org/D58731 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
