rupprecht added inline comments.

================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:193
                               RawStringFormat.Language, &PredefinedStyle)) {
-        PredefinedStyle = getLLVMStyle();
+        PredefinedStyle = getLLVMStyle(FormatStyle::LK_Cpp);
         PredefinedStyle.Language = RawStringFormat.Language;
----------------
MyDeveloperDay wrote:
> if you've set up a default argument of LK_Cpp do you need to keep supplying 
> it? if your going to supply it everywhere don't make it a default argument or 
> vice versa
> 
> This might make a much smaller patch, a little more digestable and all the 
> tests can remain as they are.
My goal was to fix all the in-tree callers but leave it as an optional arg (at 
least initially) so as to not break out of tree callers. I reduced it to what I 
actually need for this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56943/new/

https://reviews.llvm.org/D56943



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to