efriedma added inline comments.
================ Comment at: include/clang/Basic/TargetInfo.h:860 + if (!ImmSet.empty()) + return ImmSet.count(Value.getZExtValue()) != 0; + return !ImmRange.isConstrained || (Value.sge(ImmRange.Min) && Value.sle(ImmRange.Max)); ---------------- Isn't the "ImmSet.count" call still wrong? It looks like it crashes on an 128-bit immediate, and implicitly truncates a 64-bit immediate. I guess you could check `Value.isSignedIntN(32)`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58649/new/ https://reviews.llvm.org/D58649 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
