alexfh added a comment.
A few more comments.
================
Comment at: clang-tidy/tool/clang-tidy-diff.py:58
+ with lock:
+ sys.stdout.write((' '.join(command)).decode('utf-8') + '\n' +
stdout.decode('utf-8') + '\n')
+ if stderr:
----------------
nit: let's wrap this to 80 characters.
================
Comment at: clang-tidy/tool/clang-tidy-diff.py:133
+ if args.export_fixes:
+ print("error: -export-fixes and -j are mutually exclusive.")
+ sys.exit(1)
----------------
What's wrong with -export-fixes and -j? Different clang-tidy processes could
export the fixes to different files (e.g. the -export-fixes= value could be
used as a prefix of the filename with a sequential or random suffix. WDYT?
================
Comment at: clang-tidy/tool/clang-tidy-diff.py:179
+ # Run a pool of clang-tidy workers.
+ run_workers(max_task, run_tidy, task_queue, lock, args.timeout)
----------------
"start_workers" would be a clearer name, IMO.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57662/new/
https://reviews.llvm.org/D57662
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
